Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] when clicking the select all checkbox, respect instance filters #3619

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

andrei-toterman
Copy link
Contributor

Fix #3618

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (9d7e41d) to head (3ecfcd3).
Report is 72 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3619      +/-   ##
==========================================
- Coverage   88.89%   88.89%   -0.01%     
==========================================
  Files         254      254              
  Lines       14225    14444     +219     
==========================================
+ Hits        12646    12840     +194     
- Misses       1579     1604      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me: I can no longer select instances that are invisible with the select all checkbox when the filter for running instances is applied. All tests pass.

@ricab ricab marked this pull request as draft September 11, 2024 17:33
@ricab ricab marked this pull request as ready for review September 11, 2024 17:33
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ricab ricab added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@andrei-toterman andrei-toterman added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@andrei-toterman andrei-toterman added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 7840635 Sep 12, 2024
22 checks passed
@andrei-toterman andrei-toterman deleted the filter-instances-on-select-all branch September 12, 2024 09:08
ricab pushed a commit that referenced this pull request Sep 27, 2024
[gui] when clicking the select all checkbox, respect instance filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GUI] Bulk selection affects invisible instances
3 participants