Fix the bug where VirtualMachine::shutdown function throw affects multipass delete#3625

Merged

ricab merged 13 commits intomainfrom fix_bugs_of_force_stop

Sep 18, 2024

+113-82

Commits on Sep 18, 2024

[daemon] make sure the non-purge deletion on suspended vm does not invoke non-force shutdown.
georgeliao
committed
[daemon] removed the preemptive state check in daemon::stop and let the VirtualMachine::shutdown function handle that.
georgeliao
committed
[cli][daemon] move the cli suggestion part of error message to cli.
georgeliao
committed
[cli][daemon] make multipass delete error message right.
georgeliao
committed
[cli][unit test] added unit tests for the grpc::StatusCode::INVALID_ARGUMENT cases.
georgeliao
committed
[virtual machine] Improve the error message of VMStateInvalidException, so it no longer contains info of the client code.
georgeliao
committed
[daemon][cli] changed to grpc::StatusCode::FAILED_PRECONDITION instead of INVALID_ARGUMENT to avoid unwanted matches.
georgeliao
committed
[unit test] adapted the error messages of the unit tests due to exception error message change.
georgeliao
committed
[virtual machine] replace force boolean of shutdown function with enum ShutdowPolicy.
georgeliao
committed
post merge fixes
georgeliao
committed
[virtual machine] added the respective handling of checking state on suspended vm based on shutdown policy.
georgeliao
committed
[virtual machine] added comment for the ShutdownPolicy enum values.
georgeliao
committed
[qemu] localized force_shutdown true value setting so it can pair up with the false value resetting.
georgeliao
committed