Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the condition check of suspended vm on force stop #3632

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

georgeliao
Copy link
Contributor

close #3626

@georgeliao georgeliao marked this pull request as draft August 9, 2024 12:40
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (b698daa) to head (eca4986).
Report is 57 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3632   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files         254      254           
  Lines       14225    14256   +31     
=======================================
+ Hits        12644    12672   +28     
- Misses       1581     1584    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgeliao georgeliao marked this pull request as ready for review August 9, 2024 15:40
Co-authored-by: ScottH <59572507+sharder996@users.noreply.github.com>
Signed-off-by: George Liao <georgeliaojia@gmail.com>
sharder996
sharder996 previously approved these changes Aug 30, 2024
ricab and others added 2 commits August 30, 2024 11:46
Condense code to log mismatches between suspension snapshot and VM
state.
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks good to me, thanks!

@ricab ricab enabled auto-merge August 30, 2024 13:00
@ricab ricab added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit b685dbf Aug 30, 2024
14 checks passed
@ricab ricab deleted the force_stop_on_no_suspend_tag branch August 30, 2024 16:28
ricab added a commit that referenced this pull request Sep 27, 2024
correct the condition check of suspended vm on force stop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multipass stop --force can not stop suspended vm if it does not have a suspend tag
3 participants