[gui] guard against launching an instance with the name of a deleted instance #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3725 +/- ##
==========================================
- Coverage 88.93% 88.93% -0.01%
==========================================
Files 254 254
Lines 14302 14302
==========================================
- Hits 12720 12719 -1
- Misses 1582 1583 +1 ☔ View full report in Codecov by Sentry. |
andrei-toterman
force-pushed
the
mount-redesign
branch
from
932bcc8
to
b1ce55f
Compare
andrei-toterman
force-pushed
the
forbid-launch-with-deleted-name
branch
from
905460b
to
0a27a96
Compare
andrei-toterman
force-pushed
the
mount-redesign
branch
from
b1ce55f
to
2b46fba
Compare
andrei-toterman
force-pushed
the
forbid-launch-with-deleted-name
branch
from
0a27a96
to
b32a37d
Compare
andrei-toterman
force-pushed
the
forbid-launch-with-deleted-name
branch
from
b32a37d
to
26837c0
Compare
andrei-toterman
force-pushed
the
forbid-launch-with-deleted-name
branch
from
26837c0
to
b1c6608
Compare
|
Merging together with #3698. |
ricab
approved these changes
Oct 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.