Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[readme] Need VCPKG_FORCE_SYSTEM_BINARIES set on non-x64; add note (#3741) #3742

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[readme] Need VCPKG_FORCE_SYSTEM_BINARIES set on non-x64; add note (#3741) #3742

merged 1 commit into from
Nov 19, 2024

Conversation

jason-erb
Copy link
Contributor

Resolves #3741

@jason-erb jason-erb changed the title [readme] Need VCPKG_FORCE_SYSTEM_BINARIES set on ARM; add note (#3741) [readme] Need VCPKG_FORCE_SYSTEM_BINARIES set on non-x64; add note (#3741) Oct 18, 2024
ricab
ricab approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! FWIW, we do set this in our snapcraft.yaml

@ricab
Copy link
Collaborator

ricab commented Nov 19, 2024

Thanks @levkropp. I'll just merge this directly.

@ricab ricab merged commit 23ed6a7 into canonical:main Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levkropp levkropp levkropp approved these changes

@ricab ricab ricab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README: Mention requirement to set VCPKG_FORCE_SYSTEM_BINARIES on non-x64
3 participants
@jason-erb @ricab @levkropp