Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inclusive naming workflow #3

Closed
wants to merge 4 commits into from

Conversation

sed-i
Copy link

@sed-i sed-i commented Jul 25, 2023

Description

Currently, o11y CI fails for inclusive naming in this lib.
This PR addresses those issues and introduces an inclusive naming workflow.

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have bumped the version of any required library.

Copy link
Collaborator

@gruyaume gruyaume Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a project's CI should fail because one of its dependency doesn't follow the same coding standards (linting, inclusive naming, etc.) In other words, why don't you make the change in your project to only scan for its source code (and ignore the third party libs).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can that really happen? Why would the ci of a project using this lib fail if doesn't follow the same rules and coding standards? it has it's own ci at the end of the day.

@sed-i
Copy link
Author

sed-i commented Jul 27, 2023

Closing for now, as we can utilize inline ignores and .wokeignore.

@sed-i sed-i closed this Jul 27, 2023
@sed-i sed-i deleted the feature/inclusive_naming branch July 27, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants