Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inclusive naming check #75

Closed
wants to merge 1 commit into from
Closed

Remove inclusive naming check #75

wants to merge 1 commit into from

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Jul 25, 2023

The inclusive naming check has usability issues:

  • The action takes a root dir only and does not take exclusions. In order to exclude vendored charmlibs from the check, we would need to jump through some hoops. Different hoops for different repos. Or try to force the vendored libs to use the same CI we do.
  • The underlying woke tool has false positives for URLs, requiring us to do ridiculous edits such as this.

We can add this check back in a separate PR that runs periodically, separate from the PR process.

@PietroPasotti
Copy link
Contributor

a less drastic approach would be to remove the fail-on-error flag.
people will say that that means having one more useless check nobody will bother to look at...

@sed-i
Copy link
Contributor Author

sed-i commented Jul 26, 2023

a less drastic approach would be to remove the fail-on-error flag. people will say that that means having one more useless check nobody will bother to look at...

If the action will keep annotating code lines even with fail-on-error: false, then it might be the best solution: it doesn't fail but is also not entirely invisible.

@PietroPasotti
Copy link
Contributor

a less drastic approach would be to remove the fail-on-error flag. people will say that that means having one more useless check nobody will bother to look at...

If the action will keep annotating code lines even with fail-on-error: false, then it might be the best solution: it doesn't fail but is also not entirely invisible.

and with some goodwill we can even go ourselves through the alerts and decide when it's a 'false positive' or something outside of our control, and choose to ignore those

@sed-i
Copy link
Contributor Author

sed-i commented Jul 26, 2023

Closing for now in favor of inline ignores and .wokeignore.

h/t @ru-fu

@sed-i sed-i closed this Jul 26, 2023
@lucabello lucabello deleted the sed-i-patch-1 branch March 15, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants