-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPE-3264 refactor for in lib secrets #385
Conversation
dpe-3264-refactor-for-in-lib-secrets
* secrets tests
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 65.75% 65.52% -0.23%
==========================================
Files 17 17
Lines 3130 3089 -41
Branches 417 406 -11
==========================================
- Hits 2058 2024 -34
+ Misses 940 936 -4
+ Partials 132 129 -3 ☔ View full report in Codecov by Sentry. |
* current 2.9.x * current 3.1.x (secret fix in lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice!
Issue
Solution
tests/unit/test_charm_base.py