Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPE-3264 refactor for in lib secrets #385

Merged
merged 9 commits into from
Jan 26, 2024

Conversation

paulomach
Copy link
Contributor

Issue

  • new data interfaces lib encapsulates with/without secrets logic

Solution

  • Adopting changes from lib
  • moved charm base unit tests to dedicated module tests/unit/test_charm_base.py

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (990e6d9) 65.75% compared to head (a550040) 65.52%.
Report is 2 commits behind head on main.

Files Patch % Lines
lib/charms/mysql/v0/tls.py 30.76% 8 Missing and 1 partial ⚠️
lib/charms/mysql/v0/mysql.py 85.71% 2 Missing and 3 partials ⚠️
src/relations/mysql.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   65.75%   65.52%   -0.23%     
==========================================
  Files          17       17              
  Lines        3130     3089      -41     
  Branches      417      406      -11     
==========================================
- Hits         2058     2024      -34     
+ Misses        940      936       -4     
+ Partials      132      129       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* current 2.9.x
* current 3.1.x (secret fix in lib
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

@paulomach paulomach merged commit b1811f2 into main Jan 26, 2024
37 of 39 checks passed
@paulomach paulomach deleted the feature/dpe-3264-refactor-for-in-lib-secrets branch January 26, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants