-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first performance options #400
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, good default as we are deploying DB.
@delgod to decide on the architecture level... should we sit on DB default or tune them as we think we should.
Tnx Pedro!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just remember to bump the libpatch value and fix unit tests
…tor into DPE-2984-perf-work # Conflicts: # lib/charms/mysql/v0/mysql.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage 65.90% 65.90%
=======================================
Files 17 17
Lines 3103 3103
Branches 411 411
=======================================
Hits 2045 2045
Misses 929 929
Partials 129 129 ☔ View full report in Codecov by Sentry. |
Looks good to me also. Let's make those the defaults and not allow them to be changed. |
Some of the early conclusions I've found. These options will not use memory maps for files but rather allow "direct" access. The advantage: mysql has its own engines to cache data and does not need the kernel to manage file caches itself.