Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first performance options #400

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add first performance options #400

wants to merge 5 commits into from

Conversation

phvalguima
Copy link

Some of the early conclusions I've found. These options will not use memory maps for files but rather allow "direct" access. The advantage: mysql has its own engines to cache data and does not need the kernel to manage file caches itself.

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, good default as we are deploying DB.
@delgod to decide on the architecture level... should we sit on DB default or tune them as we think we should.
Tnx Pedro!

Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just remember to bump the libpatch value and fix unit tests

@paulomach paulomach marked this pull request as ready for review March 7, 2024 19:26
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (6bcd952) to head (41f6ea0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   65.90%   65.90%           
=======================================
  Files          17       17           
  Lines        3103     3103           
  Branches      411      411           
=======================================
  Hits         2045     2045           
  Misses        929      929           
  Partials      129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@7annaba3l
Copy link

Looks good to me also. Let's make those the defaults and not allow them to be changed.
We will review our auto-tuned in the next 24.10 cycle, hopefully.

@taurus-forever
Copy link
Contributor

Hi,

JFYI, I have made 1 hour tests on localhost for default and proposed parameters (twice).
Env: Laptop=>Multipass QEMU=>LXD.
For the small numbers (like 6K qpt) the difference is not really visible:
Screenshot from 2024-03-11 09-40-13

I still believe we should go with new defaults based on the previous test results done by Pedro.

P.S. Ignore significant spikes/drops on the localhost test, it looks like some laptop background tasks. No issues notices on charm/qemu itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants