Add extended attribute to get-cluster-status #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 66.39% 66.30% -0.09%
==========================================
Files 17 17
Lines 3169 3173 +4
Branches 419 420 +1
==========================================
Hits 2104 2104
- Misses 930 934 +4
Partials 135 135 ☔ View full report in Codecov by Sentry. |
arif-ali
force-pushed
the
mysql-arif-cluster-status-extended
branch
from
7861989
to
89b6eb2
Compare
arif-ali
force-pushed
the
mysql-arif-cluster-status-extended
branch
from
89b6eb2
to
b7081c4
Compare
taurus-forever
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Thank you for the contribution here!
@paulomach will we copy to K8s ourself or should we ask @arif-ali ?
we do it
carlcsaposs-canonical
approved these changes
Apr 3, 2024
shayancanonical
requested changes
Apr 4, 2024
This changes from the default boolean that was being used internally to what mysql expects. The values between 0 and 3 are valid.
arif-ali
force-pushed
the
mysql-arif-cluster-status-extended
branch
from
b7081c4
to
27d86ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes from the default boolean that was being used internally to what mysql expects. The values between 0 and 3 are valid.
Issue
Would like to get extra cluster status attributes to debug issues with mysql replication.
Solution
The solution allows us to do this via actions, rather than logging in, and getting the data manually