-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update charm tracing libs + add support for exporting traces via HTTPS #465
base: main
Are you sure you want to change the base?
Conversation
else: | ||
logger.info( | ||
"Creating CSR for %s with DNS %s and IPs %s", | ||
self.cert_subject, |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
sensitive data (certificate)
|
||
tempo_ca_cert_path.parent.mkdir(parents=True, exist_ok=True) | ||
if self.cert_handler.ca_cert: | ||
tempo_ca_cert_path.write_text(self.cert_handler.ca_cert) |
Check failure
Code scanning / CodeQL
Clear-text storage of sensitive information High
sensitive data (certificate)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general:
- please check security finding fix/dismiss
- are we silently migrating from tls lib v2 to v3? How safe is that?
- please update PR description with example how to use it properly? should tempo will always be related with both
tracing
andtracing-certificates
. Just curios, why TLS certs + CA are not returned insidetracing
if related to TLS on COS side? The separate relation is a way for human mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we silently migrating to tls_certs v3 ? Is the migration v2->v3 transparent? juju refresh mysql
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are not migrating to tls_certs v3 just yet. tls_certs v3 will be used by CertHandler only whereas the charm will use tls_certs v2 until a separate PR is created to migrate and test the upgrade from v2 to v3 for the charm
|
Blocker alert: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go on with TLS for as is for now while we pledge for proxying a single cert.
We do need to update COS documentation to include tracing though
Issue
Solution
Logs when relation with certificates operator does not exist while exporting traces
Demo
Notice that:
Span Name
search to filter all traces for the exact type of trace they are interested in!Steps to reproduce
Largely the same as https://charmhub.io/mysql/docs/h-enable-tracing
Notable differences include:
self-signed-certificates
in the COS model and runjhack imatrix fill
self-signed-certificates:certificates
from the COS modelself-signed-certificates:certificates
relation from the COS model in the machine model where MySQL is deployedjuju relate mysql:tracing-certificates self-signed-certificates:certificates