generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add charmcraft part to prime files #496
Draft
carlcsaposs-canonical
wants to merge
3
commits into
main
Choose a base branch
from
carlcsaposs-canonical-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for `prime` in `charm` part removed in charmcraft 3
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
August 2, 2024 09:44
taurus-forever
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be deprecated only and should still work... but LGTM to be the future compatible.
paulomach
approved these changes
Aug 2, 2024
carlcsaposs-canonical
added a commit
to canonical/opensearch-operator
that referenced
this pull request
Aug 14, 2024
I'd like to standardize the approach across data platform repos so that future automated tooling that may need to use this can be shared across all our repos PRs in other repos: canonical/mysql-operator#496 canonical/mysql-router-k8s-operator#298 (comment) canonical/mongodb-operator#455
Mehdi-Bendriss
pushed a commit
to canonical/opensearch-operator
that referenced
this pull request
Aug 15, 2024
I'd like to standardize the approach across data platform repos so that future automated tooling that may need to use this can be shared across all our repos PRs in other repos: canonical/mysql-operator#496 canonical/mysql-router-k8s-operator#298 (comment) canonical/mongodb-operator#455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
prime
incharm
part removed in charmcraft 3