DPE-5178 Upgrade fix for admin-address enabled charm #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomach
requested review from
carlcsaposs-canonical,
shayancanonical and
taurus-forever
paulomach
changed the title
shayancanonical
approved these changes
Sep 11, 2024
carlcsaposs-canonical
approved these changes
Sep 12, 2024
taurus-forever
approved these changes
Sep 12, 2024
| @@ -134,7 +134,7 @@ def wait_until_mysql_connection(self) -> None: | |||
| # Increment this major API version when introducing breaking changes | |||
| LIBAPI = 0 | |||
|
|
|||
| LIBPATCH = 71 | |||
| LIBPATCH = 72 | |||
There was a problem hiding this comment.
I read 72 was planned for @shayancanonical in some of reviews...
There was a problem hiding this comment.
It's the next one, so it depends who merges it first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When upgrading, the new charm will try to check for server "upgradability" using the admin_address/port of an unit not yet upgrade, i.e. it may not yet have the port open.
Solution
Use
clusteradminuser for the upgrade check, as it will default to standard port 3306.