Add abstract classes in container.py #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
here's a first draft of the socket subclass of |
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
This was referenced Jun 21, 2023
Merged
paulomach
approved these changes
Jun 22, 2023
shayancanonical
approved these changes
Jun 23, 2023
Concrete classes in rock.py As a result, workload.py and mysql_shell.py are now 100% shared between VM & K8s TODO: add docstrings, update naming Future plans: add abstraction so that charm.py can be shared between VM & k8s
carlcsaposs-canonical
force-pushed
the
abstraction-for-vm
branch
from
0053260
to
a3c2cb0
Compare
carlcsaposs-canonical
added a commit
that referenced
this pull request
Jun 26, 2023
Share most of charm.py between kubernetes & machine charm Depends on #93 --------- Co-authored-by: Paulo Machado <paulo.machado@canonical.com>
carlcsaposs-canonical
added a commit
to canonical/mysql-router-operator
that referenced
this pull request
Jun 28, 2023
DPE-1854, DPE-1910 Ported from canonical/mysql-router-k8s-operator#51 Changes from kubernetes PR: - No TLS - canonical/mysql-router-k8s-operator#93 - canonical/mysql-router-k8s-operator#97 Will re-implement legacy interface in separate PR
carlcsaposs-canonical
added a commit
that referenced
this pull request
Aug 11, 2023
Leftover from when `_bootstrap_router` was responsible for updating the pebble layer #93 moved the layer update out of `_bootstrap_router` to `Container.update_mysql_router_service`. In that PR, `_restart` should have removed its call to `_bootstrap_router` and only used `update_mysql_router_service` MySQL Router should not be bootstrapped again when TLS is enabled or disabled—it should only be restarted
carlcsaposs-canonical
added a commit
that referenced
this pull request
Aug 11, 2023
Leftover from when `_bootstrap_router` was responsible for updating the pebble layer #93 moved the layer update out of `_bootstrap_router` to `Container.update_mysql_router_service`. In that PR, `_restart` should have removed its call to `_bootstrap_router` and only used `update_mysql_router_service` MySQL Router should not be bootstrapped again when TLS is enabled or disabled—it should only be restarted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concrete classes in rock.py
As a result, workload.py and mysql_shell.py are now 100% shared between VM & K8s (VM charm subclasses
workload.AuthenticatedWorkloadto add support for unix sockets)Future plans: add abstraction so that charm.py can be shared between VM & k8s