Add extra useful methods and one bugfix. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstathis
requested review from
sed-i,
Abuelodelanada,
lucabello,
PietroPasotti and
simskij
as code owners
lucabello
previously approved these changes
Jul 13, 2023
There was a problem hiding this comment.
This implies that in the timeframe between relating a charm to a certificate provider and actually getting the certificate, we don't want the charm to keep working over HTTP, and we'd rather have it fail instead.
I'd wait to merge this until we hear what people think about it, but I'm approving for a fast merge in case we agree on this :)
lucabello
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some useful methods and fixes a bug where we assumed the relation name was "certificates".