[DPE-4224] Remove relation_{joined,changed}.emit() calls #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phvalguima
requested review from
Mehdi-Bendriss,
juditnovak and
carlcsaposs-canonical
phvalguima
force-pushed
the
DPE-4224-remove-relation-emits
branch
from
5bceb15
to
45339f1
Compare
Mehdi-Bendriss
previously approved these changes
Apr 30, 2024
Mehdi-Bendriss
previously approved these changes
Apr 30, 2024
carlcsaposs-canonical
previously approved these changes
May 1, 2024
Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>
phvalguima
dismissed stale reviews from carlcsaposs-canonical and Mehdi-Bendriss
via
bcf5561
Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>
Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>
Mehdi-Bendriss
previously approved these changes
May 1, 2024
Mehdi-Bendriss
approved these changes
May 1, 2024
carlcsaposs-canonical
approved these changes
May 1, 2024
carlcsaposs-canonical
added a commit
that referenced
this pull request
May 2, 2024
carlcsaposs-canonical
added a commit
that referenced
this pull request
May 2, 2024
Mehdi-Bendriss
pushed a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should replace calls to
relation_{joined,changed}.emit()by their end-method's handler. Otherwise we will face situations like #265, where a deferred event constantly gets called up, generates new events which also get deferred and end in a snow ball of deferrals.Closes #265