ci: make Pyright report unnecessary type ignore comments

[dimaqq]

Parent: https://warthogs.atlassian.net/browse/CHARMTECH-232

Covered in the parent epic:

• charmcraft analyse will validate that charm Python entrypoint calls ops.main
• it is static type checker’s job to ensure correct arguments to ops.main
• today, many charms do and have to do ops.main(ThisCharm) # type: ignore
• thus, type hints need to be improved so that typpe: ignore can be dropped

Plan in this story:

• upgrade pyright (not sure if strictly necessary, test: bump pyright to 1.1.377 #1332)
• enabled pyright setting reportUnnecessaryTypeIgnoreComment
• include code that calls ops.main(SomeCharm) in every which legal way in ops tests somewhere
  • pyright validates the positive case, that ops.main can be called with a charm class
• include code that calls ops.main() without a charm class
  • pyright now validates that such invocation is detected as an error
  • thus, this invocation is annotated with # type: ignore or similar
  • with the setting above, pyright also enforce that the annotation is actually needed

Ref: "How to write negative type tests?" microsoft/pyright#8803

Part 2, based on #1332

MyPy checks, pinned mypy:

• nginx-ingress-integrator-operator mypy 1.6.1 OK
• sdcore-webui-operator mypy 1.11.1 OK

Super-tox, running on host (macos)

• 58 charms pass against canonical/operator@main
• 58 charms pass against dimaqq/aoperator@pyright-reportUnnecessaryTypeIgnoreComment

[benhoyt]

Similar to my comment on #1332, let's just ensure that removing these doesn't mess with charms that use MyPy for type checking.

[tonyandrewmeyer]

Sorry, I'm not totally following these various PRs. Could you please adjust the description to make it clearer what the aim of this PR is?

[dimaqq]

I've updated the description.

[dimaqq]

re failing o11y tests, it's an upstream issue, a test dep is not pinned:
canonical/prometheus-k8s-operator#638
canonical/alertmanager-k8s-operator#286

[benhoyt]

Nice cleanup, thanks!