Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off child subreaper at OS level in reaper.Stop #412

Closed
benhoyt opened this issue Apr 24, 2024 · 0 comments · Fixed by #454
Closed

Turn off child subreaper at OS level in reaper.Stop #412

benhoyt opened this issue Apr 24, 2024 · 0 comments · Fixed by #454
Labels
Simple Nice for a quick look on a minute or two

Comments

@benhoyt
Copy link
Contributor

benhoyt commented Apr 24, 2024

Currently reaper.Stop kills the reaper tomb and does some bookkeeping, but doesn't actually make the OS call to turn off child subreaping. We should do that.

Also, while we're in there, we should clean up setChildSubreaper's return values. It returns (bool, error) right now, and it's unnecessarily confusing.
@benhoyt benhoyt added Simple Nice for a quick look on a minute or two 24.10 labels Apr 24, 2024
benhoyt added a commit to benhoyt/pebble that referenced this issue Jul 17, 2024
@benhoyt
fix: actually turn off child subreaping in reaper.Stop
5c87e47 
Fixes canonical#412
@benhoyt benhoyt mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Simple Nice for a quick look on a minute or two
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: actually turn off child subreaping in reaper.Stop benhoyt/pebble
1 participant
@benhoyt