fix(snap): build snap with Go 1.22 to fix CVE-2024-24790 #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
approved these changes
Jul 14, 2024
|
Though I believe this CVE doesn't actually affect Pebble, I have no problems merging this -- thanks. However, I also need to fix the Snap versioning before this goes out to the snap. Currently the (recent) snap versions are showing as hex commit hashes rather than version numbers (even for releases). I'll work on figuring this out today. |
benhoyt
approved these changes
Jul 15, 2024
benhoyt
changed the title
benhoyt
pushed a commit
that referenced
this pull request
Jul 15, 2024
Although not shown in the CI (because Trivy is being run with `trivy fs`, which [doesn't consider the Pebble binary](https://aquasecurity.github.io/trivy/v0.24.4/vulnerability/detection/language/)), there currently is a reported CVE in the Pebble snap (CVE-2024-24790). This CVE seems to have been fixed on newer versions of Go, but we are still using Go 1.20 to build the Pebble snap. This PR bumps this build dependency to Go 1.22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although not shown in the CI (because Trivy is being run with
trivy fs, which doesn't consider the Pebble binary), there currently is a reported CVE in the Pebble snap (CVE-2024-24790).This CVE seems to have been fixed on newer versions of Go, but we are still using Go 1.20 to build the Pebble snap.
This PR bumps this build dependency to Go 1.22.