fix(snap): set Pebble version before snap builds #450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When doing a
snapcraft remote-build
, Snapcraft will create a copy of the project in Launchpad before running the snap build.The problem is that Snapcraft seems to ignore tags while creating the copy of the project, which means the
go generate ./cmd
in thesnapcraft.yaml
'soverride-build
will never dynamically generate the right version.Solution
This PR enforces the execution of
go generate ./cmd
as a pre-requisite for running the snap build. I.e., for both local and remote builds,go generate ./cmd
must be run first, such that theVERSION
andversion_generated.go
files are staged in the repo, prior to the snap build, such that theoverride-build
script can simply rely on that information and thus ignore the missing Git refs in the LP's project.