Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daemon): allow overriding layers directory in daemon.Options #456

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

thp-canonical
Copy link
Contributor

@thp-canonical thp-canonical commented Jul 23, 2024

This allows having the layers directory in a different directory than the "layers" sub-directory inside the pebble directory.

The defaults are unchanged, but one can pass an optional non-empty string in daemon.Options{LayersDir: ...} when calling daemon.New() to use a custom location for the layers.

This also removes the need to pass pebbleDir into plan and planstate, as it really only needs the layersDir.

@flotter
Copy link
Contributor

flotter commented Jul 23, 2024

This PR relates to KO064 for supporting a different storage arrangement for a derivative project, where R/W data persisted over reboot is located at a separate location.

Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks. I like how it makes the ReadDir parameter more sensible, too.

@benhoyt benhoyt requested a review from hpidcock July 23, 2024 21:19
@thp-canonical
Copy link
Contributor Author

@hpidcock What do you think about this change?

@benhoyt
Copy link
Contributor

benhoyt commented Jul 29, 2024

Harry's busy (and working night) this week with the roadmap virtual sprint. I think this is a reasonable change and well done. Let's just go ahead and merge it.

@benhoyt benhoyt merged commit 86efdd1 into canonical:master Jul 29, 2024
16 checks passed
@thp-canonical thp-canonical deleted the layers-dir-customizable branch July 30, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants