`tls` flag is not included in relation databag

[kelkawi-a]

Steps to reproduce

1. Deploy 1 unit of postgresql-k8s charm, channel 14/stable revision 381
2. Deploy any requirer charm and relate it to the postgresql-k8s charm.

Expected behavior

The tls flag is included in the relation databag.

Actual behavior

The tls flag is not included in the relation databag.

Versions

Operating system: Ubuntu 22.04.4 LTS

Juju CLI: 3.5.3-ubuntu-amd64

Juju agent: 3.5.3

Charm revision: 381, channel 14/stable

kubectl:
Client Version: v1.30.4
Server Version: v1.26.15

[syncronize-issues-to-jira]

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/DPE-5484.

This message was autogenerated

[taurus-forever]

@carlcsaposs-canonical can you please share here your recent learning about Juju K8s-specific behavior. Tnx!

AFAIK: Juju / K8s stops the pod with loosing all the not-yet-saved data in peer data (can be a tls flag here) IF Juju/K8s is stopping the pod (charm stop event fired immediately aborting the current event execution).

It could cause tls flag loose on K8s node drain or other production related activities (maintenance/outage) keeping local patroni configs with tls enables, but without tls flag in peer data.

It also could be a mix with this Juju issue.
Example: Production K8s is heavily loaded => pod/workload needs more time to start/deploy => pebble check timeout reached (K8s liveness check triggered) => K8s kills the pod (restart pod) => we have TLS configs generated, but the tls flags are not saved in peed data.

[carlcsaposs-canonical]

yes, if kubernetes sends a sigterm, Juju immediately stops execution of the current event (causing the current event to not save data to databag) and causing a stop event to be emitted

[lucasgameiroborges]

Hey @taurus-forever and @carlcsaposs-canonical , thanks for raising this related issue!

Even thought the situation you've described can realistically happen (in such case, prob not much we could do on charm's side?), I think here we just aren't setting the tls flag at all 😅 Looks like they faced this issue on CI.

[lucasgameiroborges]

Hi! This issue should have been addressed on #719, please re-open in case you face this issue again. Thank you!

[kelkawi-a]

@lucasgameiroborges Is there a difference in fetching the tls flag from the event as opposed to the relation databag? Fetching from the relation databag does not seem to work correctly as attempted here.

[lucasgameiroborges]

Hi @kelkawi-a ! I'm not sure if this is what's happening in your PR, but I see that you are checking relation_data.get("tls") == True while in reality the databag value is a string, i.e. either "True" or "False". Does relation_data.get("tls") == "True" gives the same error?

[taurus-forever]

@lucasgameiroborges consider to highlight this in the interface specification.

[kelkawi-a]

Hi @kelkawi-a ! I'm not sure if this is what's happening in your PR, but I see that you are checking relation_data.get("tls") == True while in reality the databag value is a string, i.e. either "True" or "False". Does relation_data.get("tls") == "True" gives the same error?

The issue i'm having with the attached PR is that the condition is always evaluating to True, even though I do not have TLS enabled on the database via charm relation. I've tried relation_data.get("tls"), relation_data.get("tls") == True and relation_data.get("tls") == "True".