[MISC] Sync 14 to 16 #1038

dragomirp · 2025-07-29T17:03:13Z

Sync 14 to 16:

Remove the pg_hba trigger

Checklist

I have added or updated any relevant documentation.
I have cleaned any remaining cloud resources from my accounts.

Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>

* add starter pack and sync tutorial with VM * update deployment guides * rename how-to-guides to how-to * sync how-to guides with vm * sync references with vm * sync explanation pages with vm * add .readthedocs.yaml and reduce .gitignore scope for requirements.txt file * fix some formatting issues * sync backup guides with vm * fix misc. build errors and sync tutorial with vm * add doc ci checks * remove discourse sync workflow * polish tutorial and deploy guide * specify channel on all deploy commands * sync misc. pages with vm * minor README update with new documentation link * ignore docs folder in development workflows * remove sphinx python dependency check workflow * update home page

* Fix auth username pattern Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix unit test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix another ocurrence of the pattern Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: rename interfaces-endpoints for consistency with VM * update references to interfaces-and-endpoints * add rediraffe sphinx extension and redirect mapping list

* add starter pack and sync tutorial with VM * update deployment guides * rename how-to-guides to how-to * sync how-to guides with vm * sync references with vm * sync explanation pages with vm * add .readthedocs.yaml and reduce .gitignore scope for requirements.txt file * fix some formatting issues * sync backup guides with vm * fix misc. build errors and sync tutorial with vm * add doc ci checks * remove discourse sync workflow * polish tutorial and deploy guide * specify channel on all deploy commands * sync misc. pages with vm * minor README update with new documentation link * ignore docs folder in development workflows * remove sphinx python dependency check workflow * update home page * fix some broken links * fix broken links * fix spelling errors in docs * fix spelling errors in other markdown files * small spelling fix

* Hold database created hook for pg_hba changes * Restore the old blocking hook * 16/edge lib changes * Set to expected patch version

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

The pgBackRest activity (backup creation, stanza initialisation, etc) could take minutes, as a result every minute logs rotation could move the current log A.log to A.log_$date.log and will be moved further as logrorate rule operates all *.log files in the folder: > /var/snap/charmed-postgresql/common/var/log/pgbackrest/*.log { ... It results in: -rw------- 1 postgres postgres 0 Feb 18 09:25 all-server.log -rw------- 1 postgres postgres 0 Feb 18 09:19 all-server.log-20250218_09:18.log -rw------- 1 postgres postgres 0 Feb 18 09:20 all-server.log-20250218_09:18.log-20250218_09:19.log -rw------- 1 postgres postgres 0 Feb 18 09:21 all-server.log-20250218_09:18.log-20250218_09:19.log-20250218_09:20.log -rw------- 1 postgres postgres 0 Feb 18 09:22 all-server.log-20250218_09:18.log-20250218_09:19.log-20250218_09:20.log-20250218_09:21.log -rw------- 1 postgres postgres 0 Feb 18 09:23 all-server.log-20250218_09:18.log-20250218_09:19.log-20250218_09:20.log-20250218_09:21.log-20250218_09:22.log -rw------- 1 postgres postgres 1793 Feb 18 09:24 all-server.log-20250218_09:18.log-20250218_09:19.log-20250218_09:20.log-20250218_09:21.log-20250218_09:22.log-20250218_09:23.log The poposed fix: * move the log file to the new name without .log suffix. * use datetime format matching MySQL charms Example: -rw------- 1 postgres postgres 12 Feb 18 09:28 all-server.log -rw------- 1 postgres postgres 322 Feb 18 09:29 all-server.log-20250218_0918 -rw------- 1 postgres postgres 7344 Feb 18 09:30 all-server.log-20250218_0918

* Update canonical/data-platform-workflows action to v32 * Switch release flow --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dragomir Penev <dragomir.penev@canonical.com>

* Update libs * Workflow tweaks * Remove from_environ warning

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* More aggressive idle checks * Explicit idle * Idle period when relating to the test app * Remove second start * Remove log warning * Hold create db hook for longer * Bump the pg_hba checker timeout * Don't update config * Bump timeout * Try to just append to pg_hba * Sync hba changes before creating db resources * Force regenerate hash and config on leader * Use current host to check hba * Update libs * Compare to local hash * Cla check for 16/edge * Don't defer peer change before init * Add back app check * Revert back to just updating peer data * Only sync hba once initially set * Bump timeout * Don't filter appends to pg_hba * Append the rel users directly to the user map * Add idle timeout * Remove trigger * Sleep longer * Set extra user roles * Always update hash * Bump sleep period * Revert the trigger * Move generate_user_hash to charm * Conditional hash update * Try to sort keys * Revert to relation user hash * Try to reduce the amount of ifs * Remove trigger * Blocked test app

codecov · 2025-07-29T17:04:13Z

Codecov Report

❌ Patch coverage is 60.81081% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.69%. Comparing base (efd9e19) to head (3fecd7a).
⚠️ Report is 1 commits behind head on 16/edge.

Files with missing lines	Patch %	Lines
src/charm.py	48.27%	13 Missing and 2 partials ⚠️
scripts/authorisation_rules_observer.py	80.00%	6 Missing ⚠️
src/authorisation_rules_observer.py	40.00%	6 Missing ⚠️
src/relations/postgresql_provider.py	60.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           16/edge    #1038      +/-   ##
===========================================
+ Coverage    72.33%   72.69%   +0.35%     
===========================================
  Files           14       14              
  Lines         3680     3713      +33     
  Branches       524      531       +7     
===========================================
+ Hits          2662     2699      +37     
+ Misses         821      815       -6     
- Partials       197      199       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dragomirp · 2025-07-29T17:07:30Z

lib/charms/postgresql_k8s/v0/postgresql.py

Not bumping patch, since it is to be replaced by v1.

Should v0/postgresql.py lib file be deleted?

We need to port predefined roles to k8s to switch to v1.

dragomirp · 2025-07-30T00:56:29Z

tests/integration/ha_tests/test_async_replication.py

+    await ops_test.model.wait_for_idle(apps=[APPLICATION_NAME], status="blocked")
+    await ops_test.model.wait_for_idle(apps=[DATABASE_APP_NAME], status="active")


Additional changes on top of the merge. 16 is re-relating the test app so needs to check for blocked.

taurus-forever · 2025-07-30T11:28:18Z

lib/charms/postgresql_k8s/v0/postgresql.py

Should v0/postgresql.py lib file be deleted?

marceloneppel

Thank you so much!

github-actions bot and others added 20 commits May 28, 2025 15:07

Sync docs from Discourse (#864)

9d77611

Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>

Update ghcr.io/canonical/charmed-postgresql Docker tag to v14.18 (#983)

14a14cc

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Add redirects for all charmhub pages (14) (#994)

2275dc4

* chore: rename interfaces-endpoints for consistency with VM * update references to interfaces-and-endpoints * add rediraffe sphinx extension and redirect mapping list

fix: add forward slash to redirect paths (#998)

a6fb522

Renovate team (#999)

d37a671

[MISC] Hold database created hook for pg_hba changes (#1001)

3e9b4d0

* Hold database created hook for pg_hba changes * Restore the old blocking hook * 16/edge lib changes * Set to expected patch version

fix: internal reference typo (#1006)

96e594b

Lock file maintenance Python dependencies (#962)

4fddda5

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

update links to ops tutorial and charm (#1015)

bd38bc3

[MISC] Update libs and remove warning (#1014)

78c7bb3

* Update libs * Workflow tweaks * Remove from_environ warning

Lock file maintenance Python dependencies (#1012)

be08648

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Delete runner password (#1023)

31f2e5c

remove markdown-linter action (#1028)

ac55896

Merge branch 'main' into sync

897c4e8

dragomirp added the not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes label Jul 29, 2025

dragomirp changed the title ~~Sync~~ [MISC] Sync 14 to 16 Jul 29, 2025

github-actions bot added the Libraries: Out of sync label Jul 29, 2025

dragomirp commented Jul 29, 2025

View reviewed changes

Ignore blocked

3fecd7a

dragomirp force-pushed the sync branch from f665492 to 3fecd7a Compare July 29, 2025 22:32

dragomirp commented Jul 30, 2025

View reviewed changes

dragomirp marked this pull request as ready for review July 30, 2025 00:57

dragomirp requested a review from a team July 30, 2025 00:58

dragomirp requested review from marceloneppel and taurus-forever and removed request for a team July 30, 2025 00:58

taurus-forever approved these changes Jul 30, 2025

View reviewed changes

lib/charms/postgresql_k8s/v0/postgresql.py

Copy link

Contributor

taurus-forever Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should v0/postgresql.py lib file be deleted?

marceloneppel approved these changes Jul 30, 2025

View reviewed changes

dragomirp merged commit cffdd76 into 16/edge Jul 30, 2025
245 of 253 checks passed

dragomirp deleted the sync branch July 30, 2025 12:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MISC] Sync 14 to 16 #1038

[MISC] Sync 14 to 16 #1038

Uh oh!

dragomirp commented Jul 29, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

dragomirp Jul 29, 2025

Uh oh!

taurus-forever Jul 30, 2025

Uh oh!

dragomirp Jul 30, 2025

Uh oh!

dragomirp Jul 30, 2025

Uh oh!

taurus-forever Jul 30, 2025

Uh oh!

marceloneppel left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		await ops_test.model.wait_for_idle(apps=[APPLICATION_NAME], status="blocked")
		await ops_test.model.wait_for_idle(apps=[DATABASE_APP_NAME], status="active")

[MISC] Sync 14 to 16 #1038

[MISC] Sync 14 to 16 #1038

Uh oh!

Conversation

dragomirp commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

codecov bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dragomirp Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

taurus-forever Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

dragomirp Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

dragomirp Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

taurus-forever Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

marceloneppel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dragomirp commented Jul 29, 2025 •

edited

Loading

codecov bot commented Jul 29, 2025 •

edited

Loading