-
Notifications
You must be signed in to change notification settings - Fork 27
Mark unstable tests #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark unstable tests #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am slightly surprised with amount of tests we are marking as unstable
.
What is your definition of unstable? :-D
From the nightly failures, we must mark ha-self-healing-integration
for sure (constantly failing).
Failures in tls
and charm-integration
tests looks identically:
unit-postgresql-k8s-1: 01:45:01 ERROR unit.postgresql-k8s/1.juju-log database-peers:0: Uncaught exception while in charm code:
...
ConnectionRefusedError: [Errno 111] Connection refused
...
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x7f09a7823100>: Failed to establish a new connection: [Errno 111] Connection refused
and IMHO required investigation and fix (to stabilize significant amount of tests).
LGTM, as you know what you are doing here, but please schedule timeout investigation above in this/next pulse. Tnx!
Hi Alex! I forgot to add more details to the PR description, sorry about that. I used the list of nightly failed tests to mark them as unstable. Yeah, I'm going to schedule some time to investigate and fix them in the next pulse. Thanks. |
* Mark unstable tests * Reorganize TLS test to use unstable mark * Mark test_redeploy_charm_same_model as unstable
Issue
Jira issue: DPE-1356
Some integration tests fail transiently and sometimes make the development slower.
Solution
Mark them as unstable and create tasks for solving each of them.
Context
New Jira issues were created for each of the tests that need to be fixed. They're listed on DPE-1356.
The TLS tests was changed to match the text in the logs without all the details related to TLS version or bits (because it may change when updating the database version).
Testing
Tested on multiple runs locally and on CI.
Release Notes
Mark unstable tests.