Simplify password parsing in action results #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceloneppel
changed the title
marceloneppel
force-pushed
the
fix-action-password-key
branch
from
156a670 to
750d2d2
Compare
marceloneppel
changed the title
dragomirp
approved these changes
Mar 14, 2023
taurus-forever
approved these changes
Mar 14, 2023
|
Just for the history, mysql-k8s returns both username and password: |
delgod
approved these changes
Mar 16, 2023
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-x64-postgresql-k8s-operator
that referenced
this pull request
Jul 11, 2024
github-actions bot
added a commit
to canonical/test-runners-2-github-x64-postgresql-k8s-operator
that referenced
this pull request
Jul 12, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-arm64-postgresql-k8s-operator
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Jira issue: DPE-1489
All the passwords returned by the get and set password actions have the username as a prefix, but who requested it already knows the user, so it's not needed to have it specified in the action result, only the password.
Solution
Remove the username prefix from the password key in the actions results.
Context
Reference: canonical/mongodb-operator#172 (comment) (request from Mykola).
I also contacted Marc about the Zookeeper charms.
Testing
Fixed the existing tests.
Release Notes
Simplify password parsing in action results.