Skip to content

Conversation

dragomirp
Copy link
Contributor

Port of canonical/postgresql-operator#1173

Disable data directory removal

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@dragomirp
Copy link
Contributor Author

We don't need to patch the config, since there's no 16/stable release yet. Should I add to be the same as VM?

Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.02%. Comparing base (84ddfee) to head (f426119).
⚠️ Report is 2 commits behind head on 16/edge.

❌ Your project status has failed because the head coverage (67.02%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           16/edge    #1104   +/-   ##
========================================
  Coverage    67.02%   67.02%           
========================================
  Files           15       15           
  Lines         4194     4194           
  Branches       615      615           
========================================
  Hits          2811     2811           
  Misses        1156     1156           
  Partials       227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dragomirp dragomirp added the bug Something isn't working as expected label Sep 23, 2025
@dragomirp dragomirp marked this pull request as ready for review September 23, 2025 15:38
@dragomirp dragomirp requested review from a team, marceloneppel and taurus-forever and removed request for a team September 23, 2025 15:38
@marceloneppel
Copy link
Member

We don't need to patch the config, since there's no 16/stable release yet. Should I add to be the same as VM?

I think it's not needed. We can have it on the single kernel library later.

@dragomirp dragomirp merged commit c057d62 into 16/edge Sep 24, 2025
211 of 223 checks passed
@dragomirp dragomirp deleted the dpe-8337-pgrewind-dataloss branch September 24, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected Libraries: Out of sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants