[DPE-8439] No reinit #1114
[DPE-8439] No reinit #1114
Conversation
github-actions
bot
added
the
Libraries: Out of sync
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (67.28%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1114 +/- ##
===========================================
- Coverage 67.30% 67.28% -0.03%
===========================================
Files 16 16
Lines 3762 3723 -39
Branches 541 537 -4
===========================================
- Hits 2532 2505 -27
+ Misses 1072 1061 -11
+ Partials 158 157 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if not self._patroni.member_started and self._patroni.is_database_running: | ||
| try: | ||
| container.restart(self.postgresql_service) | ||
| logger.info("restarted Patroni because it was not running") | ||
| except ChangeError: | ||
| logger.error("failed to restart Patroni after checking that it was not running") | ||
| return False | ||
| return True |
There was a problem hiding this comment.
Looks practically identical to thee restart check in _on_update_status() itself:
postgresql-k8s-operator/src/charm.py
Lines 1582 to 1598 in 6abe374
| if self._handle_processes_failures(): | ||
| return | ||
|
|
There was a problem hiding this comment.
Reinit removed and the restart check seems to be duplicated to the one above.
dragomirp
requested review from
a team,
marceloneppel and
taurus-forever
and removed request for
a team
| @property | ||
| def is_database_running(self) -> bool: | ||
| """Returns whether the PostgreSQL database process is running (and isn't frozen).""" | ||
| container = self._charm.unit.get_container("postgresql") | ||
| output = container.exec(["ps", "aux"]).wait_output() | ||
| postgresql_processes = [ | ||
| process | ||
| for process in output[0].split("/n") | ||
| if "/usr/lib/postgresql/14/bin/postgres" in process | ||
| ] | ||
| # Check whether the PostgreSQL process has a state equal to T (frozen). | ||
| return any(process for process in postgresql_processes if process.split()[7] != "T") | ||
|
|
There was a problem hiding this comment.
Dead code. Also 14 specific.
Checklist