Skip to content

Conversation

@marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Oct 8, 2025

Issue

The charm does not remove the old revisions of a secret after updating it.

Solution

Port of canonical/postgresql-operator#1195.

Implement the secret-remove event handler.

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.31%. Comparing base (cca6e6a) to head (04dd300).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
+ Coverage   73.28%   73.31%   +0.03%     
==========================================
  Files          15       15              
  Lines        3904     3909       +5     
  Branches      573      573              
==========================================
+ Hits         2861     2866       +5     
  Misses        829      829              
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marceloneppel marceloneppel added the not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes label Oct 8, 2025
@marceloneppel marceloneppel changed the title Remove secret's old revision [DPE-8498] Remove secret's old revision Oct 8, 2025
@marceloneppel marceloneppel marked this pull request as ready for review October 8, 2025 18:44
@marceloneppel marceloneppel merged commit a7e8af0 into main Oct 9, 2025
206 of 212 checks passed
@marceloneppel marceloneppel deleted the remove-secret-old-revision branch October 9, 2025 11:30
marceloneppel added a commit that referenced this pull request Oct 13, 2025
This reverts commit a7e8af0.

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: Out of sync not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants