Don't consider failed backups when restoring #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taurus-forever
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Might be an interesting idea for MySQL too, CC: @shayancanonical
delgod
approved these changes
Mar 17, 2023
dragomirp
approved these changes
Mar 17, 2023
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-x64-postgresql-k8s-operator
that referenced
this pull request
Jul 15, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-arm64-postgresql-k8s-operator
that referenced
this pull request
Jul 16, 2024
github-actions bot
added a commit
to canonical/test-runners-2-github-x64-postgresql-k8s-operator
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Jira issue: DPE-1507
Failed backups are being considered in the restore action.
Solution
Add a flag to the function that list backup ids to return or not failed backups.
Check for failed backups in
_on_create_backup_action.Don't consider failed backups in
_on_restore_action.Context
Change copied from canonical/postgresql-operator#83 (comment).
Testing
Unit and integration tests for the backup/restore features will be implemented on DPE-556.
Release Notes
Don't consider failed backups when restoring.