Skip to content

Conversation

@dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Oct 29, 2025

  • Check juju version before removing a secret revision
  • Remove legacy admin relation test

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@github-actions github-actions bot added the Libraries: Out of sync The charm libs used are out-of-sync label Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.34%. Comparing base (f660c4f) to head (6a2ee81).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
- Coverage   73.34%   73.34%   -0.01%     
==========================================
  Files          15       15              
  Lines        3913     3916       +3     
  Branches      573      574       +1     
==========================================
+ Hits         2870     2872       +2     
- Misses        829      830       +1     
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dragomirp dragomirp marked this pull request as ready for review October 29, 2025 10:23
@dragomirp dragomirp requested review from a team, marceloneppel and taurus-forever and removed request for a team October 29, 2025 10:24
@dragomirp dragomirp changed the title [DPE-8550] Check juju version before removing revision [DPE-8550] Check juju version before removing revision and remove discourse charmers test Nov 14, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discourse charmers charm has not been updated since 2021, is superseded by a newer charm and fails to deploy locally and on CI. I don't think there's another db-admin charm to use, so removing the test.

@dragomirp dragomirp merged commit 17753b6 into main Nov 25, 2025
1416 of 1492 checks passed
@dragomirp dragomirp deleted the revision-removal-version-check branch November 25, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants