-
Notifications
You must be signed in to change notification settings - Fork 27
[DPE-8550] Check juju version before removing revision and remove discourse charmers test #1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
==========================================
- Coverage 73.34% 73.34% -0.01%
==========================================
Files 15 15
Lines 3913 3916 +3
Branches 573 574 +1
==========================================
+ Hits 2870 2872 +2
- Misses 829 830 +1
Partials 214 214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tests/integration/test_db_admin.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The discourse charmers charm has not been updated since 2021, is superseded by a newer charm and fails to deploy locally and on CI. I don't think there's another db-admin charm to use, so removing the test.
Checklist