-
Notifications
You must be signed in to change notification settings - Fork 27
Remove k8s resources on application removal #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WRFitch
approved these changes
Aug 28, 2022
shayancanonical
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
github-actions bot
added a commit
to canonical/test-runners-2-github-x64-postgresql-k8s-operator
that referenced
this pull request
May 14, 2024
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
* Add k8s resources cleanup * Improve code * Uncomment previous tests * Remove duplicated and imcomplete test * Fix imports order * Minor fixes * Test idle period * Test lib versions * Change * Remove version test * Revert change * Revert change * Revert change * Uncomment tests * Fix CI workflow * Fix tests * Add test about redeployment * Revert some test changes * Improve code * Fix docstring * Add pytest marks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Context
charm.py, the on stop event removes the k8s resources created in on install and also by Patroni.resources.yamltwo unneeded resources were removed.Testing
Release Notes