[DPE-2903] Toggle plugins in one go #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
commented
Nov 12, 2023
| self.unit.status = original_status | ||
| extension = plugins_exception.get(extension, extension) | ||
| extensions[extension] = enable | ||
| self.unit.status = WaitingStatus("Updating extensions") |
Contributor
Author
There was a problem hiding this comment.
We can no longer tell if we are enabling or disabling and which plugin.
dragomirp
commented
Nov 12, 2023
Comment on lines
-155
to
-157
| # Enable/disable extensions in the new database. | ||
| self.charm.enable_disable_extensions(database) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This will be done anyway on line 153
taurus-forever
approved these changes
Nov 13, 2023
Contributor
taurus-forever
left a comment
taurus-forever
left a comment
There was a problem hiding this comment.
LGTM. Can we improve the test to make sure at least some extension(s) are enabled?
marceloneppel
approved these changes
Nov 16, 2023
Member
marceloneppel
left a comment
marceloneppel
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the great improvement!
Contributor
Author
Will add additional test for this as part of DPE-2844, since I want to unblock pending plugin PRs. |
marceloneppel
pushed a commit
that referenced
this pull request
Nov 22, 2023
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
marceloneppel
pushed a commit
that referenced
this pull request
Nov 22, 2023
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Starting a connection for each db to enable or disable plugins will take more and more time as the number of plugins increases.
Solution
Open a single connection per db and enable or disable the plugins in one go.