[MISC] Always check peer data for legacy secrets #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceloneppel
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
LGTM!
It looks like the change to the get_secret method prevents an unexpected password change at
postgresql-k8s-operator/src/charm.py
Line 662 in 155ccae
juditnovak
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
So, normally this is somethig that the lib was supposed to do for you.
However (thanks to the wonderful Postgres unittests -- that now will be also migrated to the lib test coverage) I had to realize that there is a bug on this behavior with the new get_secret(), set_secret() methods.
canonical/data-platform-libs#174
So please go ahead with the change (for now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #454
Try to always do the translation from peer data to secrets in case of very old revisions being updated.