[DPE-5833] Create new PostgreSQL version 16 charm #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16/edge #788 +/- ##
===========================================
- Coverage 75.53% 74.90% -0.64%
===========================================
Files 12 11 -1
Lines 3115 3383 +268
Branches 466 486 +20
===========================================
+ Hits 2353 2534 +181
- Misses 621 660 +39
- Partials 141 189 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Fix ports Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Remove unused import Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Remove unused charm library and fix unit tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix identation Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Bump libs * Conditional set_ports logic * Unit test * Don't expect juju managed resources --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> Co-authored-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
| juju: | ||
| - agent: 2.9.51 # renovate: juju-agent-pin-minor | ||
| libjuju: ==2.9.49.1 # renovate: latest libjuju 2 | ||
| allure_on_amd64: false |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
dragomirp
reviewed
Mar 18, 2025
| name: Promote charm | ||
| uses: canonical/data-platform-workflows/.github/workflows/_promote_charm.yaml@v30.2.0 | ||
| with: | ||
| track: '16' |
dragomirp
reviewed
Mar 18, 2025
Comment on lines
+308
to
+321
| logger.info("rerelate test app") | ||
| await ops_test.model.applications[DATABASE_APP_NAME].remove_relation( | ||
| "database", f"{APPLICATION_NAME}:{FIRST_DATABASE_RELATION_NAME}" | ||
| ) | ||
| await ops_test.model.wait_for_idle( | ||
| apps=[DATABASE_APP_NAME, APPLICATION_NAME], status="active", raise_on_blocked=True | ||
| ) | ||
| await ops_test.model.relate( | ||
| DATABASE_APP_NAME, f"{APPLICATION_NAME}:{FIRST_DATABASE_RELATION_NAME}" | ||
| ) | ||
| await ops_test.model.wait_for_idle( | ||
| apps=[DATABASE_APP_NAME, APPLICATION_NAME], status="active", raise_on_blocked=True | ||
| ) | ||
|
|
There was a problem hiding this comment.
DB is owned by the user of the test app in the other model, so the test app in this model loses access to the public schema. Rerelating to change ownership. Not sure why this isn't failing on VM.
dragomirp
reviewed
Mar 18, 2025
| DATABASE_APP_NAME, | ||
| application_name=DATABASE_APP_NAME, | ||
| num_units=1, | ||
| channel="14/stable", |
There was a problem hiding this comment.
Was testing the channel.
dragomirp
reviewed
Mar 18, 2025
|
|
||
| @pytest.mark.group(1) | ||
| # No arm edge | ||
| @markers.amd64_only |
taurus-forever
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the 4-PR bundle to merge PostgreSQL 16. See doc for further info: https://docs.google.com/document/d/1K4xMxKDOiHfdCTc_hxMh6bW1DCZ6HC6wa6g8tAJAtno/edit?tab=t.0