Skip to content

[DPE-6910] Remove duplicate parameters specification #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2025
Merged

[DPE-6910] Remove duplicate parameters specification #896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea32220
Remove duplicate parameters specification
marceloneppel Mar 20, 2025
30c0ab3
Enable config test
marceloneppel Mar 20, 2025
5d0d73b
Fix linting
marceloneppel Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions templates/patroni.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ bootstrap:
logging_collector: 'on'
wal_level: logical
shared_preload_libraries: 'timescaledb,pgaudit'
{%- if pg_parameters %}
{%- for key, value in pg_parameters.items() %}
{{key}}: {{value}}
{%- endfor -%}
{% endif %}
{%- if restoring_backup %}
method: pgbackrest
pgbackrest:
Expand Down
4 changes: 1 addition & 3 deletions tests/integration/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,7 @@ async def test_config_parameters(ops_test: OpsTest, charm) -> None:
"optimizer_parallel_tuple_cost": ["-1", "0.1"]
}, # config option is between 0 and 1.80E+308
{"profile": [test_string, "testing"]}, # config option is one of `testing` or `production`
# {
# "profile_limit_memory": {"127", "128"}
# }, # config option is between 128 and 9999999
{"profile_limit_memory": ["127", "128"]}, # config option is between 128 and 9999999
{
"request_backslash_quote": [test_string, "safe_encoding"]
}, # config option is one of `safe_encoding` and `on` and `off`
Expand Down