[DPE-7691] Bump snap revision to 197/198 to use _daemon_ (584792) #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1024 +/- ##
========================================
Coverage 70.29% 70.29%
========================================
Files 16 16
Lines 3807 3807
Branches 545 545
========================================
Hits 2676 2676
Misses 1001 1001
Partials 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
taurus-forever
force-pushed
the
alutay/use_daemon_
branch
from
0af9e2c to
dd46399
Compare
2 tasks
Reasoning: * Use _daemon_ (UID:584792) instead of snap_daemon (UID:584788) See: https://forum.snapcraft.io/t/system-usernames/13386 * Stop creating $SNAP_COMMON/data/db (unnecessary) + polishing * add postgresql-16-repack * temporary disable upgrade tests due to snap user change
taurus-forever
force-pushed
the
alutay/use_daemon_
branch
from
dd46399 to
270c2bb
Compare
taurus-forever
changed the title
taurus-forever
commented
Jul 9, 2025
Comment on lines
+1331
to
+1333
| subprocess.check_call(["mkdir", "-p", "/home/_daemon_"]) # noqa: S607 | ||
| subprocess.check_call(["chown", "_daemon_:_daemon_", "/home/_daemon_"]) # noqa: S607 | ||
| subprocess.check_call(["usermod", "-d", "/home/_daemon_", "_daemon_"]) # noqa: S607 |
There was a problem hiding this comment.
It smells a bit, and might be no longer necessary (AFAIK it was some snap workaround)... but let's test it AS IS for now.
There was a problem hiding this comment.
It's still needed, as long as we switch user to _daemon_.
Comment on lines
+92
to
+94
| _check_call.assert_any_call(["mkdir", "-p", "/home/_daemon_"]) | ||
| _check_call.assert_any_call(["chown", "_daemon_:_daemon_", "/home/_daemon_"]) | ||
| _check_call.assert_any_call(["usermod", "-d", "/home/_daemon_", "_daemon_"]) |
There was a problem hiding this comment.
same as above.
Comment on lines
+8
to
+10
| systems: | ||
| - -ubuntu-24.04 | ||
| - -ubuntu-24.04-arm |
There was a problem hiding this comment.
Will be reverted after merge and edge publishing.
marceloneppel
approved these changes
Jul 9, 2025
dragomirp
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The snap user
snap_daemonhas been deprecated by SNAP team,see: https://forum.snapcraft.io/t/system-usernames/13386
Also the newer charmed-postgresql snap is available with new parts there.
Solution
_daemon_(UID:584792) instead ofsnap_daemon(UID:584788)Tests will be re-enabled after releasing to edge, as we do not
provide upgrade path for snap ownership changes.
Upgrade path is unnecessary here, as it is a first stable release to PG16 charm.
Checklist