[DPE-7594] Add custom users to pg_hba filter #1072
Conversation
dragomirp
added
the
not bug or enhancement
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (66.02%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1072 +/- ##
===========================================
+ Coverage 65.84% 66.02% +0.17%
===========================================
Files 17 17
Lines 4178 4179 +1
Branches 609 610 +1
===========================================
+ Hits 2751 2759 +8
+ Misses 1284 1276 -8
- Partials 143 144 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
changed the title
| if user in ( | ||
| "backup", | ||
| "monitoring", | ||
| "operator", | ||
| "postgres", | ||
| "replication", | ||
| "rewind", | ||
| ): | ||
| continue |
There was a problem hiding this comment.
Copied from the trigger.
There was a problem hiding this comment.
Please create a dedicated Jira ticket on Mohamed to decide the behavior here, as we are adding here backward compatibility to the current behavior which is not the best way to do in modernly hardened charm.
Thank you!
dragomirp
requested review from
a team,
marceloneppel and
taurus-forever
and removed request for
a team
| if plugins: | ||
| self.enable_disable_extensions(dict.fromkeys(plugins, True), database) |
There was a problem hiding this comment.
Lib change for PGB.
| if user in ( | ||
| "backup", | ||
| "monitoring", | ||
| "operator", | ||
| "postgres", | ||
| "replication", | ||
| "rewind", | ||
| ): | ||
| continue |
There was a problem hiding this comment.
Please create a dedicated Jira ticket on Mohamed to decide the behavior here, as we are adding here backward compatibility to the current behavior which is not the best way to do in modernly hardened charm.
Thank you!
| else: | ||
| logger.debug(f"User {user} has no databases to connect to") |
There was a problem hiding this comment.
The structure of relations_user_databases_map changed with logical replication. Should it be ported back to 14/edge?
| else: | ||
| logger.debug(f"User {user} has no databases to connect to") |
3 participants
Don't skip custom users when generating pg_hba configuration
Checklist