[DPE-8005] Handle empty region #1117
Conversation
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (64.57%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1117 +/- ##
===========================================
- Coverage 64.57% 64.57% -0.01%
===========================================
Files 17 17
Lines 4325 4327 +2
Branches 667 668 +1
===========================================
+ Hits 2793 2794 +1
Misses 1351 1351
- Partials 181 182 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit e8d42b7.
| else: | ||
| if return_code != 0: | ||
| logger.error(stderr) | ||
| logger.error(f"Failed to run pgbackrest: {stderr}") |
There was a problem hiding this comment.
Add more context so we have an idea where the error happened.
| # If the check command doesn't succeed, remove the stanza name | ||
| # and rollback the configuration. | ||
| logger.exception(e) | ||
| logger.exception("Failed to initialise stanza:") |
There was a problem hiding this comment.
Exception context will be logged automatically by logger.exception.
There was a problem hiding this comment.
Don't create a bucket, so that we can test bucket creation.
dragomirp
requested review from
a team,
marceloneppel and
taurus-forever
and removed request for
a team
| "bucket": "data-charms-testing", | ||
| "path": f"/postgresql-k8s/{uuid.uuid1()}", | ||
| "region": "", | ||
| "region": "us-east-1", |
There was a problem hiding this comment.
Based on headers from 16/edge runs: https://github.com/canonical/postgresql-operator/actions/runs/17406719352/job/49489833563#step:12:3100
taurus-forever
left a comment
taurus-forever
left a comment
There was a problem hiding this comment.
Can you please update PR description for the future (answering how we are handling it better).
Q: is region mandatory on GCP? If so, how users are informed about missing region? The exception says nothing about missing region.
Do I miss something here? Tnx!
Handle empty region when creating backups.
Checklist