Skip to content

Conversation

@marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Oct 8, 2025

Issue

The charm does not remove the old revisions of a secret after updating it.

Solution

Port of #1195.

Implement the secret-remove event handler.

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.57%. Comparing base (3a00ea4) to head (b709081).
⚠️ Report is 1 commits behind head on 16/edge.

❌ Your project status has failed because the head coverage (64.57%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           16/edge    #1207      +/-   ##
===========================================
+ Coverage    64.53%   64.57%   +0.04%     
===========================================
  Files           17       17              
  Lines         4339     4344       +5     
  Branches       671      671              
===========================================
+ Hits          2800     2805       +5     
  Misses        1357     1357              
  Partials       182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marceloneppel marceloneppel added the not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes label Oct 8, 2025
@marceloneppel marceloneppel changed the title Remove secret's old revision [DPE-8395] Remove secret's old revision Oct 8, 2025
@marceloneppel marceloneppel marked this pull request as ready for review October 8, 2025 18:41
@marceloneppel marceloneppel merged commit 782292f into 16/edge Oct 9, 2025
245 of 249 checks passed
@marceloneppel marceloneppel deleted the remove-secret-old-revision-16 branch October 9, 2025 11:31
marceloneppel added a commit that referenced this pull request Oct 13, 2025
This reverts commit 782292f.

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: Out of sync not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants