fix departing unit subtleties #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ops 1.5.2 introduced a fix to the harness' handling for departing unit tracking for events. This uncovered a subtle error in the tests here. remove_relation was triggering the "departing" relation data key to be inserted into the local charm's data because the local charm had been added to the relation units list (which is not really how that is intended to be used). This was causing the delete_user method to be called earlier than intended and caused assertion failures in the on_relation_broken test. The fix is to not add the local unit to the relation units. But then the relation departed test that checks for the "departing" data key wasn't working. So for now, we can add the local unit to the relation in that test only.
marceloneppel
approved these changes
Sep 7, 2022
|
Integration failure. Seems unlikely to be caused by this (test code) change? |
Yeah, them definitely are not related to the change. I will investigate further what is causing that. Thanks for the fix @rwcarlsen! |
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
ops 1.5.2 introduced a fix to the harness' handling for departing unit tracking for events. This uncovered a subtle error in the tests here. remove_relation was triggering the "departing" relation data key to be inserted into the local charm's data because the local charm had been added to the relation units list (which is not really how that is intended to be used). This was causing the delete_user method to be called earlier than intended and caused assertion failures in the on_relation_broken test. The fix is to not add the local unit to the relation units. But then the relation departed test that checks for the "departing" data key wasn't working. So for now, we can add the local unit to the relation in that test only.
github-actions bot
added a commit
to canonical/test-runners-2-github-x64-postgresql-operator
that referenced
this pull request
May 19, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-x64-postgresql-operator
that referenced
this pull request
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ops 1.5.2 introduced a fix to the harness' handling for departing unit tracking for events. This uncovered a subtle error in the tests here. remove_relation was triggering the "departing" relation data key to be inserted into the local charm's data because the local charm had been added to the relation units list (which is not really how that is intended to be used). This was causing the delete_user method to be called earlier than intended and caused assertion failures in the on_relation_broken test. The fix is to not add the local unit to the relation units. But then the relation departed test that checks for the "departing" data key wasn't working. So for now, we can add the local unit to the relation in that test only.