-
Notifications
You must be signed in to change notification settings - Fork 26
[DPE-3199] Internal secrets management from library #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6cdafd
to
5b8d460
Compare
2150845
to
ecfb3cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests!
ecfb3cd
to
bfce91e
Compare
bfce91e
to
927fd46
Compare
cdc071e
to
db8f991
Compare
db8f991
to
f408d65
Compare
dragomirp
approved these changes
Jan 11, 2024
delgod
approved these changes
Jan 11, 2024
marceloneppel
approved these changes
Jan 11, 2024
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
* data_interfaces PeerRelation * Postgres charm using PeerRelation * Adding unittest parametrize * Unittests adjusted and extended * Disabling broken db_admin tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data_platform_libs/data_interface v26
, together with additional tests.The library now includes support for handling Peer Relation Data (similar to Cross-charm Relation Data), hiding all complexity of choice between databag and Juju Secrets.
The same code is also tested against Juju 3.1.7: #314