fix: secret tests must only set app secrets as the leader #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s this like Juju.
tonyandrewmeyer
changed the title
|
The test failures don't seem like they should be related to this change (which is only in one - parametrised - unit test), but if they are, let me know and I can work on addressing whatever happened. |
dragomirp
approved these changes
Jan 15, 2024
marceloneppel
approved these changes
Jan 16, 2024
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
…s this like Juju. (canonical#322)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Juju secrets only the leader unit has admin access to app secrets, and ops 2.9 and above enforce this in
Harnessto match the Juju behaviour.One test (
test_migration_from_single_secret) currently does aset_secretcall (via the charm's `set_secret method) when acting as a non-leader unit. This would not work in production, and fails in ops 2.9.The PR simply calls
set_leader()appropriately around theset_secretcall, so that the rest of the test (in all three parameterised versions) remain unchanged.