TLS on Patroni REST API #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tls-integration-test #33 +/- ##
========================================================
+ Coverage 60.62% 60.67% +0.04%
========================================================
Files 6 6
Lines 795 801 +6
Branches 123 123
========================================================
+ Hits 482 486 +4
- Misses 285 287 +2
Partials 28 28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
marceloneppel
requested review from
MiaAltieri,
WRFitch,
delgod,
marcoppenheimer,
paulomach,
shayancanonical and
zmraul
WRFitch
approved these changes
Sep 21, 2022
| Whether TLS is enabled/disabled on Patroni REST API. | ||
| """ | ||
| unit_address = get_unit_address(ops_test, unit_name) | ||
| tls_ca = await get_tls_ca(ops_test, unit_name) |
There was a problem hiding this comment.
Could you return False here if not tls_ca?
There was a problem hiding this comment.
Added on 334a50d.
MiaAltieri
approved these changes
Sep 21, 2022
| planned_units: number of units planned for the cluster | ||
| superuser_password: password for the operator user | ||
| replication_password: password for the user used in the replication | ||
| tls_enabled: whether TLS is enabled |
There was a problem hiding this comment.
This specific parameter is related to whether TLS is already enabled or not, different from the tests, where we have parameters related to verify whether TLS is enabled.
|
|
||
| # The CA bundle file is used to validate the server certificate when | ||
| # TLS is enabled, otherwise True is set because it's the default value | ||
| # for the verify parameter. |
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
* Add workaround for Patroni REST API TLS * Improve TLS status retrieval * Readd checks * Add additional check
github-actions bot
added a commit
to canonical/test-runners-2-github-x64-postgresql-operator
that referenced
this pull request
May 20, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-x64-postgresql-operator
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Context
REPLICATINGwhat was already reviewed on TLS on Patroni REST API postgresql-k8s-operator#38 to the PostgreSQL VM charm.FOCUSyour review on them):tests/integration/helpers.pyandtests/integration/test_tls.py: new checks to ensure the API is accepting TLS connections and differently from the k8s charm now we use the TLS CA to verify the server certificate.Testing
Release Notes