Skip to content

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Feb 1, 2024

  • Restore codecov and add configuration
  • Update charm libs

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (6790adc) 78.98% compared to head (c9dcbec) 79.94%.
Report is 35 commits behind head on main.

Files Patch % Lines
src/charm.py 88.88% 5 Missing and 4 partials ⚠️
src/relations/db.py 70.00% 2 Missing and 1 partial ⚠️
src/config.py 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   78.98%   79.94%   +0.95%     
==========================================
  Files          10       10              
  Lines        2151     2169      +18     
  Branches      349      344       -5     
==========================================
+ Hits         1699     1734      +35     
+ Misses        381      368      -13     
+ Partials       71       67       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +1 to +2
github_checks:
annotations: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable annotations

Comment on lines +6 to +7
default:
target: 70%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall coverage should be over 70%

Comment on lines +9 to +10
default:
target: 33%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit delta should be at least 33% covered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log messages are slightly different in the latest lib.

@dragomirp dragomirp changed the title [MISC] Restore Codecov [MISC] Restore Codecov and update libs Feb 1, 2024
@dragomirp dragomirp marked this pull request as ready for review February 1, 2024 14:07
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx! IMHO, it is our future!

@dragomirp dragomirp merged commit cf04016 into main Feb 2, 2024
@dragomirp dragomirp deleted the codecov branch February 2, 2024 13:40
BON4 pushed a commit to BON4/postgresql-operator that referenced this pull request Apr 23, 2024
* Update codecov/codecov-action action to v4

* Try to revive code cov

* Old codecov

* Codecov configs

* Bump libs

* Fix unit test

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants