Skip to content

Conversation

BON4
Copy link
Contributor

@BON4 BON4 commented Apr 23, 2024

Issue #441

This pull request is re-open of pull request that was closed by me due to CLA check fix.

All this cases should be covered:

  • Test Application. VM resources is removed after application removal. Install app, remove app (removal test), check no garbage left.
  • Test Unit. Re-Installation. Remove unit with --force --no-wait, storage should be detached.
  • Test Unit. Garbage ignorance. Charm should deploy in dirty environment with garbage storage.
  • Test Application. Application should deploy in dirty environment with garbage storage from another application.

@BON4 BON4 requested a review from marceloneppel April 30, 2024 10:08
@dragomirp
Copy link
Contributor

Hi, @BON4, please fix the linting errors.

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

P.S. checking the test output and this line looks suspicious:

unit-postgresql-test-app-1: 12:00:55 ERROR unit.postgresql-test-app/1.juju-log upgrade:0: Failed to list PostgreSQL database users: could not translate host name "None" to address: Temporary failure in name resolution

Is PostgreSQL charm returns None as a hostname in relation? I worth a question in Matrix at least... maybe even bugreport if true.

@taurus-forever
Copy link
Contributor

@marceloneppel can we merge this? P.S. Tests finally happy! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants