-
Notifications
You must be signed in to change notification settings - Fork 26
Add test_smoke
test re-open
#454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test_smoke
test re-open
#454
Conversation
Hi, @BON4, please fix the linting errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
P.S. checking the test output and this line looks suspicious:
unit-postgresql-test-app-1: 12:00:55 ERROR unit.postgresql-test-app/1.juju-log upgrade:0: Failed to list PostgreSQL database users: could not translate host name "None" to address: Temporary failure in name resolution
Is PostgreSQL charm returns None as a hostname in relation? I worth a question in Matrix at least... maybe even bugreport if true.
@marceloneppel can we merge this? P.S. Tests finally happy! \o/ |
Issue #441
This pull request is re-open of pull request that was closed by me due to CLA check fix.
All this cases should be covered:
--force --no-wait
, storage should be detached.