[DPE-4616] Add support for tracing with tempo-k8s #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if server_cert is None: | ||
| logger.warning( | ||
| f"{charm}.{server_cert_getter} returned None; sending traces over INSECURE connection." |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
shayancanonical
requested review from
taurus-forever,
dragomirp,
marceloneppel and
lucasgameiroborges
taurus-forever
approved these changes
Jun 4, 2024
marceloneppel
approved these changes
Jun 5, 2024
dragomirp
reviewed
Jun 5, 2024
dragomirp
approved these changes
Jun 6, 2024
marceloneppel
approved these changes
Jun 10, 2024
shayancanonical
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We would like to be able to instrument our charm and generate traces to discover inefficiencies in charm code execution. The observability team has developed a charm for tempo that we would like to integrate with.
Solution
Integrate with the tempo charm
Considerations
edgeuntil it is release to stable with some critical changes