Skip to content

Legacy interface fails to relate if event attributes are None #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 24, 2023
Merged

Legacy interface fails to relate if event attributes are None #52

merged 5 commits into from
Jan 24, 2023

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Jan 16, 2023 •
edited by atlassian bot
Loading

Issue

  • DPE-1049
  • Relating fails if event.app is None

Solution

  • More resilient check for database name and extensions

Context

  • The VM charm is also affected by perpetual blocked status if extensions are requested, so the check to unblock is also copied

Testing

  • Adds integration test for relating with weebl
  • Adds unit tests for extension unblocking logic

Release Notes

  • More resilient check for database name and extensions
  • Unblock charm when relations requesting extensions are broken

@codecov
Copy link

codecov bot commented Jan 16, 2023 •
edited
Loading

Codecov Report

Merging #52 (9ea722e) into main (c36b503) will increase coverage by 0.46%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   65.35%   65.82%   +0.46%     
==========================================
  Files           6        6              
  Lines         814      828      +14     
  Branches      115      123       +8     
==========================================
+ Hits          532      545      +13     
  Misses        258      258              
- Partials       24       25       +1
Impacted Files Coverage Δ
src/relations/db.py 72.18% <83.33%> (+2.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dragomirp dragomirp changed the title DPE-1049 Legacy interface fails to relate if event attributes are None Jan 16, 2023
@dragomirp dragomirp marked this pull request as ready for review January 16, 2023 23:02
dragomirp
dragomirp commented Jan 16, 2023
View reviewed changes
marceloneppel
marceloneppel approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Dragomir!

taurus-forever
taurus-forever approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dragomirp dragomirp merged commit acc1dff into main Jan 24, 2023
@dragomirp dragomirp deleted the dpe-1049-weebl branch January 24, 2023 12:52
@dragomirp dragomirp restored the dpe-1049-weebl branch January 24, 2023 13:43
dragomirp added a commit that referenced this pull request Jan 24, 2023
@dragomirp
Revert "Legacy interface fails to relate if event attributes are None (…
bdd862a 
…#52)"

This reverts commit acc1dff.
@dragomirp dragomirp mentioned this pull request Jan 24, 2023
Closed
@dragomirp dragomirp deleted the dpe-1049-weebl branch January 25, 2023 16:43
BON4 pushed a commit to BON4/postgresql-operator that referenced this pull request Apr 23, 2024
@dragomirp
Legacy interface fails to relate if event attributes are None (canoni…
0ee6ec5 
…cal#52)

* More resilient database name check and clearing of extensions blocked
status

* Unpinning libjuju test

* Revert "Unpinning libjuju test"

This reverts commit 7c6ed45.

* Move clearing of blocked status to _on_relation_broken

* Unit tests
github-actions bot added a commit to canonical/test-runners-2-github-x64-postgresql-operator that referenced this pull request May 25, 2024
@github-actions
Allure report canonical#52
a83742b
github-actions bot added a commit to canonical/test-runners-2-azure-arm64-postgresql-operator that referenced this pull request May 25, 2024
@github-actions
Allure report canonical#52
d0b5bf5
github-actions bot added a commit to canonical/test-runners-2-is-x64-postgresql-operator that referenced this pull request May 25, 2024
@github-actions
Allure report canonical#52
81add33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taurus-forever taurus-forever taurus-forever approved these changes

@marceloneppel marceloneppel marceloneppel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dragomirp @taurus-forever @marceloneppel