[DPE-4820] Fix GCP backup test #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 68.76% 68.66% -0.11%
==========================================
Files 11 11
Lines 3000 3003 +3
Branches 530 532 +2
==========================================
- Hits 2063 2062 -1
- Misses 819 822 +3
- Partials 118 119 +1 ☔ View full report in Codecov by Sentry. |
dragomirp
approved these changes
Jul 3, 2024
…up-test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
dragomirp
approved these changes
Jul 8, 2024
lucasgameiroborges
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Timeouts are happening on the test_restore_on_new_cluster after PITR was merged through #391 (due to a different status being set by the charm).
Solution
Fixed the expected status in the tests (changing the constant from
ANOTHER_CLUSTER_REPOSITORY_ERROR_MESSAGEtoMOVE_RESTORED_CLUSTER_TO_ANOTHER_BUCKET).Also, I restored the restore-related application databag fields to empty values to avoid the charm being unable to use new S3 credentials from the relation.
Unit tests are being updated at #528.