Fix change WAL settings fixture #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 68.39% 68.39%
=======================================
Files 6 6
Lines 886 886
Branches 133 133
=======================================
Hits 606 606
Misses 256 256
Partials 24 24 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dragomirp
approved these changes
Feb 9, 2023
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
* Fix error that is raised when calling change WAL settings * Remove unused import * Add reformatted file
github-actions bot
added a commit
to canonical/test-runners-2-github-x64-postgresql-operator
that referenced
this pull request
May 27, 2024
github-actions bot
added a commit
to canonical/test-runners-2-azure-arm64-postgresql-operator
that referenced
this pull request
May 27, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-x64-postgresql-operator
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Jira ticket: DPE-1190
The fixture called
wal_settingswas failing if another error happened stopping the SST test.Solution
Start the stopped units (they were stopped inside the SST test). This makes the Patroni REST API available again to enable the fixture to rollback the changes in the WAL settings (that were made in the beginning of the test by this fixture) on all the units.
Context
Still need to address transient errors (that triggered the error fixed by this PR in the past) in another PR.
Testing
Manually tested locally.
Release Notes
Fix change WAL settings fixture to start the stopped units.