[MISC] Use more meaningful group naming for multi-group tests #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
=======================================
Coverage 70.89% 70.89%
=======================================
Files 12 12
Lines 3048 3048
Branches 539 539
=======================================
Hits 2161 2161
Misses 771 771
Partials 116 116 ☔ View full report in Codecov by Sentry. |
lucasgameiroborges
requested review from
marceloneppel,
taurus-forever,
dragomirp and
a-velasco
dragomirp
reviewed
Sep 25, 2024
|
|
||
|
|
||
| @pytest.mark.group(1) | ||
| @pytest.mark.group("main_tests") |
There was a problem hiding this comment.
Something like high availability might be a more meaningful label.
There was a problem hiding this comment.
oops, this is different from K8s: we're on test_new_relations, not self_healing - what about new_relations_tests?
There was a problem hiding this comment.
merging this so it gets out of the way - we can always create follow ups if better ideas come!
dragomirp
approved these changes
Sep 25, 2024
taurus-forever
approved these changes
Sep 26, 2024
|
|
||
|
|
||
| @pytest.mark.group(1) | ||
| @pytest.mark.group("main_tests") |
marceloneppel
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VM port of canonical/postgresql-k8s-operator#707